Conversation
There was a problem hiding this comment.
memcpy seems to be a complicated way to read data from this pointer. why not reinterpret cast & de-reference?
There was a problem hiding this comment.
done in next patch
filelist.json
Outdated
There was a problem hiding this comment.
why the indentation change?
There was a problem hiding this comment.
fixed in next patch
There was a problem hiding this comment.
This function gets the SVE vector length for each element in the tensor and compares it with remaining. I think we should get it once before the execute_window_loop and reuse. The svcnt in the wrapper namespace can help with that.
There was a problem hiding this comment.
done in next patch
There was a problem hiding this comment.
I don't think we need to do this here again. The parameter remaining is already the min(vector_len, remaining-in-the-caller). We're taking another min on top of this result, i.e. if I'm not mistaken, we're doing smth like
min(min(x,y)) = min(x,y)
Change-Id: I7a0c7bd1154b9cb7f35c7fd1c3b8ad54698f8799 Signed-off-by: Pablo Marquez Tello <pablo.tello@arm.com>
morgolock
force-pushed
the
pr/topkv_sve_kernels
branch
from
1deb127 to
7944860
Compare
2 participants
Change-Id: I7a0c7bd1154b9cb7f35c7fd1c3b8ad54698f8799